feat: scoped-unfreeze by reason bitmask (#607) - #699
Merged
thlpkee20-wq merged 2 commits intoJul 29, 2026
Conversation
- Add #[repr(u32)] to FreezeReason with explicit discriminants and to_bitmask() helper for safe bitmask operations - Introduce DataKey2::HolderFreezeMask storing a u32 bitmask instead of a single FreezeReason, with legacy EmergencyFreeze fallback on read - emergency_freeze_holder now ORs reason bits into the mask; idempotent when the reason is already active - Add clear_freeze_reason(reason) to clear a single reason bit; only fully unfreezes (removes key, emits frz_clr) when mask == 0; emits frz_rc (freeze_reason_cleared) for partial clears - emergency_unfreeze_holder delegates to clear_freeze_reason for backward compatibility - process_ofac_attestation ORs SanctionsMatch bit with legacy migration - Add get_holder_freeze_reasons query returning the raw bitmask - Update storage layout schema with HolderFreezeMask and pre-existing missing registrations - Add 10 comprehensive tests covering multi-reason freeze/clear, idempotency, event emission, and OFAC+manual interaction
|
@believetimothy Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #607. Adds reason-scoped unfreeze via u32 bitmask so clearing one reason does not unfreeze the holder while other reasons remain active.